Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: block parser spec longer timeout for container #6583

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Sep 11, 2023

If your PR failed with metadata client test on timeout waiting for done.
This change will help by waiting more and not fail this test.

@nopcoder nopcoder self-assigned this Sep 11, 2023
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@nopcoder nopcoder added area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Sep 11, 2023
@nopcoder nopcoder requested a review from a team September 11, 2023 17:53
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
I think that it also Closes #2455

@nopcoder
Copy link
Contributor Author

Looks great. I think that it also Closes #2455

Not sure it fixes this one - I think we should not invoke the container as a daemon and wait for completion. But it looks like the library in this version doesn't provide this functionality.
It looks like it is was built to run background services.
So I'll keep this one open for future improvements.

@nopcoder nopcoder merged commit d17c315 into master Sep 12, 2023
@nopcoder nopcoder deleted the fix/metadata-client-timeout branch September 12, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Improvements or additions to tests exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants